Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event titles in UITableView #23

Open
clseva opened this issue Jan 5, 2013 · 12 comments
Open

Event titles in UITableView #23

clseva opened this issue Jan 5, 2013 · 12 comments
Assignees

Comments

@clseva
Copy link

clseva commented Jan 5, 2013

Hi Chris,

Since v1.2.5 (v1.2.6 included) I’ve noticed that clicking on different events added previously they are displayed in UITableView with the same title without refreshing correctly. For example, if I add a new event titled "First Event" and then another event titled "Second Event", when you click on these dates both events appear with the same title "Second Event" in TableView. I've tested on iOS 5 and 6 with CoreData datasource and this doesn't happen in previous versions (v1.2.3). In addition, I've verified that this happens with the example provided in the module. The events are added properly and their data is returned correctly in "event:clicked" eventlistener too, but their titles in UITableView are not updated.

Thank you so much for the active support to this module!

@aaronce
Copy link

aaronce commented Jan 8, 2013

Hi Chris, I'm also getting this issue - the events are created on different dates correctly but the titles and other information seem to copy across..

on closer inspection placing a onclick "event:clicked" reveals that the data is actually stored correctly though, so it seems to be more of a UI issue.

also thanking you for an outstanding module!

@ChrisRM
Copy link
Member

ChrisRM commented Jan 8, 2013

I got the same result, but don't have time to fix it just yet. I'll have a look later today.

ChrisRM pushed a commit that referenced this issue Jan 9, 2013
New events now added with correct content in the tableview.
@ChrisRM
Copy link
Member

ChrisRM commented Jan 9, 2013

Had a hard time figuring out this one. Try it out and let me know how it goes.

@aaronce
Copy link

aaronce commented Jan 10, 2013

Brilliant, works perfectly now. I also tried to look under the hood on this but couldn't find the issue.
Thanks a lot Chris.

@clseva
Copy link
Author

clseva commented Jan 10, 2013

Chris, excellent work. It works with added events properly now.

I'm sorry to bother you more, but just missing to fix it when deleting with "swipe-to-delete". Using the same example, if you delete a second event added, the first event dissapears in tableview. Only reloading or clicking on next/previous month, events appear in tableview updated correctly.

Thank you so much for the hard work.

@ChrisRM
Copy link
Member

ChrisRM commented Jan 10, 2013

Looking into it.. :-) thanks for testing guys.

@ChrisRM
Copy link
Member

ChrisRM commented Jan 10, 2013

Hmm, im not able to reproduce this one. Provide me with some sample code, and I'll fix it asap

@clseva
Copy link
Author

clseva commented Jan 10, 2013

Hi Chris, see sample code:
https://gist.github.com/4501042

And a video example (I'll delete it at the end):
http://youtu.be/R6iHIvplSnM

@ChrisRM
Copy link
Member

ChrisRM commented Jan 10, 2013

Nice job, let it stay for a while so I can have a look when im finished at work.

@clseva
Copy link
Author

clseva commented Jan 28, 2013

Hi Chris,
Have you been able to take a look at it?

Thanks a lot.

@ChrisRM
Copy link
Member

ChrisRM commented Jan 31, 2013

I'll see what I can do this weekend. Quite busy atm.

@ghost ghost assigned ChrisRM Feb 15, 2013
@ChrisRM
Copy link
Member

ChrisRM commented Mar 12, 2013

Fixed in release 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants