This repository has been archived by the owner on May 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(typeahead): prevent accidental form submission on ENTER
- Loading branch information
1 parent
85647c9
commit 253c49f
Showing
2 changed files
with
11 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
253c49f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pkozlowski-opensource this commit breaks our use of typeahead, could help me understand why you would want to prevent enter when the typeahead is closed? wouldn't you actually want to allow the user to submit the form in that case?
253c49f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scamden this commit originally came from a pull request and I guess I wasn't careful enough while working on it, my bad.
The idea in the original PR was to prevent accidental forms submission when a popup with matches is open (which kind of makes sense as you wouldn't probably like to prevent form submission when people are selecting a match).
Discussion about this issue is in #1298
Based on all the discussion I'm close to reversing it now.
253c49f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ok thanks!
253c49f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for reversing