Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Tooltip does not appear when used with ngAnimate #2951

Closed
red-0ne opened this issue Nov 11, 2014 · 2 comments
Closed

Tooltip does not appear when used with ngAnimate #2951

red-0ne opened this issue Nov 11, 2014 · 2 comments
Labels
component: tooltip needs: investigation type: bug
Milestone
0.12

Comments

@red-0ne
Copy link

red-0ne commented Nov 11, 2014

Using b4832c4, tooltip does not show up when the application contains the ngAnimate module.

http://plnkr.co/edit/fF6FOb4R9dCsyyPxD2Ez?p=preview

Notice that when removing ttScope.$digest() from src/tooltip/tooltip.js#L240 the tooltips appear again.
@chrisirhc chrisirhc mentioned this issue Nov 11, 2014
Closed
@chrisirhc chrisirhc added this to the 0.12 milestone Nov 11, 2014
@chrisirhc
Copy link
Contributor

It looks like that $digest call isn't necessary anyway. The fix (b4832c4) for the ngRepeat issue didn't need this change, I just reverted the previous change.

I'll remove this unecessary scope $digest. I think it's because ngAnimate is attempting to operate on an element that's not on the $rootElement since it hasn't been appended to the body at that point.

@red-0ne
Copy link
Author

red-0ne commented Nov 11, 2014

Yes, As if the digest prematurely stabilizes the model so the ngAnimate does not detect changes.

@chrisirhc chrisirhc mentioned this issue Nov 14, 2014
Closed
OronNadiv pushed a commit to lanetix/bootstrap that referenced this issue Nov 18, 2014
@chrisirhc
fix(tooltip): remove extra digest causing incompatibility
5dc8e8e 
In Angular 1.3.1, when using tooltips with ngAnimate, this extra $digest
call seems to break ngClass. This is an extra call to ngAnimate and it
shouldn’t be called since the tooltip hasn’t been added to the DOM.

I was unable to create a test case to test compatibility with ngAnimate.

Fixes angular-ui#2951
Fixes angular-ui#2959
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Nov 19, 2014
@chrisirhc
fix(tooltip): incorrect position when text wraps
33d7343 
The $digest that was removed in 32c470 is actually necessary to get the
tooltip contents rendered. The rendered content is important when the
tooltip is on the right edge. See Plunker in angular-ui#2995:
http://plnkr.co/edit/8GZ5F5zj3Xe6IinXQz74?p=preview

Fixes angular-ui#2995

Correctly fixes angular-ui#2951 without removing $digest.
@chrisirhc chrisirhc mentioned this issue Nov 19, 2014
Closed
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Nov 19, 2014
@chrisirhc
fix(tooltip): incorrect position when text wraps
3b59062 
The $digest that was removed in 32c470 is actually necessary to get the
tooltip contents rendered. The rendered content is important when the
tooltip is on the right edge. See Plunker in angular-ui#2995:
http://plnkr.co/edit/8GZ5F5zj3Xe6IinXQz74?p=preview

Reverts change in 32c470 (angular-ui#2995) but fixes it in another way.

Fixes angular-ui#2995
Fixes angular-ui#2992
Fixes angular-ui#2951
Closes angular-ui#2996
chrisirhc added a commit that referenced this issue Feb 20, 2015
@chrisirhc
fix(tooltip): incorrect position when text wraps
5726e3e 
The $digest that was removed in 32c470 is actually necessary to get the
tooltip contents rendered. The rendered content is important when the
tooltip is on the right edge. See Plunker in #2995:
http://plnkr.co/edit/8GZ5F5zj3Xe6IinXQz74?p=preview

Reverts change in 32c470 (#2995) but fixes it in another way.

Fixes #2995
Fixes #2992
Fixes #2951
Closes #2996
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: tooltip needs: investigation type: bug
Projects
None yet
Milestone
0.12
Development

Successfully merging a pull request may close this issue.

fix(tooltip): incorrect position when text wraps chrisirhc/angular-ui-bootstrap
2 participants
@chrisirhc @red-0ne