Skip to content

Commit

Permalink
fix(Build): Allow Angular 1.3.x upper constraint
Browse files Browse the repository at this point in the history
Had incorrect semver syntax for Bower ('>=1.2.16 <=1.3.x') which worked
for semver but not BOWER'S semver, which is different. This updated syntax
is correct.

Thanks to @jgilchrist for walking me through it.

Closes #4064
  • Loading branch information
c0bra committed Jul 28, 2015
1 parent d48fc96 commit 13d93f4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/grunt/plugins.js
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ module.exports = function(grunt) {

// Create the bower.json file
grunt.registerTask('update-bower-json', function () {
var currentTag = semver.clean( util.getCurrentTag() );
var currentTag = semver.clean( util.getVersion() );

var taggedReleaseDir = path.join(path.resolve(process.cwd()), 'dist', 'release', currentTag);

Expand Down Expand Up @@ -308,7 +308,7 @@ module.exports = function(grunt) {
'main': releaseFiles,
'ignore': [],
'dependencies': {
'angular': '>=1.2.16 <=1.3.16' // Note: bower will install 1.2.28 when <=1.3.x is specified...
'angular': '>=1.2.16 1.3.x'
},
'repository': pkg.repository,
'homepage': 'http://ui-grid.info',
Expand Down

0 comments on commit 13d93f4

Please sign in to comment.