fix(uiGridMenu): Only run applyHide when not shown

applyHide() was running on all GRID_SCROLL events, whether or not the menu was visible. This was causing excess $digest() loops.
angular-ui · Nov 13, 2014 · 91bf06f · 91bf06f
1 parent 79f6c21
commit 91bf06f
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/js/core/directives/ui-grid-menu.js b/src/js/core/directives/ui-grid-menu.js
@@ -123,9 +123,11 @@ function ($compile, $timeout, $window, $document, gridUtil, uiGridConstants) {
 
     // *** Auto hide when click elsewhere ******
       var applyHideMenu = function(){
-        $scope.$apply(function () {
-          $scope.hideMenu();
-        });
+        if ($scope.shown) {
+          $scope.$apply(function () {
+            $scope.hideMenu();
+          });
+        }
       };
 
       if (typeof($scope.autoHide) === 'undefined' || $scope.autoHide === undefined) {