-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(grouping): Add option groupingNullLabel, to group null and undef…
…ined values together. Fixes #3271
- Loading branch information
ndudenhoeffer
committed
May 6, 2015
1 parent
efd3798
commit 9fbb1b8
Showing
1 changed file
with
13 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9fbb1b8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we conflating
undefined
andnull
as being equal to one another, when they're not?null
is a value, whereastypeof(x) === 'undefined'
means there is no value.As a workaround, I have to walk all my datasets and replace
null
values with the string"null"
before I hand off the data to ui-grid, so users can distinguish a cell value ofnull
from a cell with no value (undefined
). Bummer.Is my workaround required, or is there another way to instruct ui-grid to disambiguate
null
values from fields with no values?