Skip to content

Commit

Permalink
fix(uiGridRenderContainer): Inherit position
Browse files Browse the repository at this point in the history
Change position: relative to position: inherit. This will prevent the
footer from overlapping the viewport content incorrectly.  It appears to
not break anything else that's not currently broken...

Fixes #2030
  • Loading branch information
c0bra committed Nov 7, 2014
1 parent 555ddec commit fd35328
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/less/body.less
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

.ui-grid-render-container {
position: relative;
position: inherit;
// overflow: hidden;

.border-radius(0, @gridBorderRadius, @gridBorderRadius, 0);
Expand Down

1 comment on commit fd35328

@morungos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it might be affecting OSX scroll bars. When I skip this property, the horizontal scroll bar on a Mac is correctly placed. With this amendment, it is spaced above the bottom of the grid by the width of a scroll bar, and overlaps the content. This happens on both Chrome and Firefox on the Mac. Although it's true scroll bars on the Mac were already broken, this might be obscuring a deeper issue on that one.

Please sign in to comment.