-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mousewheel scrolling does not scroll completely in containers missing vertical scrollbar #3772
Comments
You might want to merge #3769 before looking at this, but it gets the same results with or without it. |
Note: this happens in Chrome, Firefox, and IE10. Doesn't seem browser-related. |
Note: The margin-top that gets set from scrolling the right-most container (the one with the scrollbar) is 60px more than the others. 60px == two rows. |
Apparently |
I thought maybe that the mousewheel handler was allowing an extra call to It's just a normal scroll event I think... |
Note: It may be because the scrollbar-less container doesn't fire scroll events. So the one with scrollbars is able to fire an extra event to get to the bottom that the other ones can't. We may need to somehow manually set the scrollTop to the max if we're at/past 100% and not at the max scroll distance (canvas height - viewport height) |
The problem is that containers that have |
Looks like we've been calculating scroll percentage wrong. The max scroll length should match the scroll height of the viewport but it's off by the height of the scrollbar, which causes the scroll percentage to go BEYOND 100%. The mousewheel handler prevents firing this > 100% scroll event, and thus the container does not scroll. |
Containers that have overflow: hidden set are not able to naturally scroll to 100%, because they cannot handle native scroll events; only mousewheel. It's a long discussion; see #3772 for notes. This change catches a mousewheel event that should put the container at the max scroll position (basically scrollHeight - offsetHeight) and manually sets the scrollTop to that amount. Fixes #3772
@c0bra if you could take a look at this, I'd appreciate it. I'm baffled.
In 203_pinning
The text was updated successfully, but these errors were encountered: