Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External Sorting does not work with Sorting #4155

Closed
JLLeitschuh opened this issue Aug 10, 2015 · 1 comment
Closed

External Sorting does not work with Sorting #4155

JLLeitschuh opened this issue Aug 10, 2015 · 1 comment
Assignees
@JLLeitschuh
Labels
grid-core grid-grouping needs: decision type: bug

Comments

@JLLeitschuh
Copy link
Contributor

Problem

When grouping with server sorting enabled the data does not sort first.

Steps to reproduce:

  1. Try to group by name.

http://plnkr.co/edit/Fa9TmlYZTIjPqu5xOThU?p=preview

Desired result

When grouping the server sort should be triggered when grouping.

Is this as intended or is it a bug?
@JLLeitschuh
Copy link
Contributor Author

I'm pretty sure that this could be solved by adding this line:

grid.api.core.raise.sortChanged(grid, grid.getColumnSorting());

Here:
https://github.com/angular-ui/ui-grid/blob/master/src/features/grouping/js/grouping.js#L684

@JLLeitschuh JLLeitschuh self-assigned this Aug 11, 2015
JLLeitschuh added a commit that referenced this issue Aug 12, 2015
@JLLeitschuh
fix(grouping): Grouping now raises a sort changed event
d30b1ad 
Grouping was not calling sort changed which meant that external sorting
with grouping wasn't working.
 - Adds a call to raise a `sortChanged` event when grouping.
 - Additionally adds a test to grouping to ensure that this event is
   raised.

Closes #4155
@JLLeitschuh JLLeitschuh mentioned this issue Aug 12, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JLLeitschuh JLLeitschuh

Labels
grid-core grid-grouping needs: decision type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JLLeitschuh