-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inactivity timeout not cleared #17
Comments
hi Filipe, My version of ibrowse which is in the works has set_inac_timer implemented as follows: set_inac_timer(State) -> cancel_timer(State#state.inactivity_timer_ref), set_inac_timer(State#state{inactivity_timer_ref = undefined}, get_inac_timeout(State)). set_inac_timer(State, Timeout) when is_integer(Timeout) -> Ref = erlang:send_after(Timeout, self(), timeout), State#state{inactivity_timer_ref = Ref}; set_inac_timer(State, _) -> State. What do you think? |
Hi Chandru, Seems fine to me. If it takes long, I'll add mine to CouchDB, since we plan to release 1.0.2 soon. cheers |
I'll get it done asap. Shouldn't take more than a day or two. |
Great! :) |
Is this connected to this problem I've encountered? | now() tupple | Some internal data | Data received Even though I receive keepalive data from twitter, after 2minutes ibrowse times-out. |
Yes, sounds like it is related. A new release is imminent with a fix. |
Yes, that's definitely the same error I was having. |
Fixed in ibrowse-2.1.0 |
Hi Chandru.
I found out that, with ibrowse 2.0.x, if I use a worker for several request and the first request had an activity timeout X specified in the options, the timer is never cleared, causing a subsequent request (after X milliseconds) to fail.
Patch at:
http://github.com/fdmanana/ibrowse/commit/072d4f865fb77609e6cd75639a36264fbfb19933
Cheers
The text was updated successfully, but these errors were encountered: