Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented the completion suggester for auto-complete functionality #376

Merged
merged 1 commit into from
Nov 17, 2013
Merged

Conversation

gmarz
Copy link
Contributor

@gmarz gmarz commented Nov 4, 2013

http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/search-suggesters-completion.html

As the documentation states, this is currently an experimental feature of Elasticsearch, but it works pretty well and it completes the suggestion offering of NEST (as we already have the Term and Phrase suggesters).

@Mpdreamz
Copy link
Member

Mpdreamz commented Nov 4, 2013

Awesome++ this is a pretty big feature PR. Many many thanks @gmarz looking forward to pulling it in 👍

@gmarz
Copy link
Contributor Author

gmarz commented Nov 4, 2013

Great. There are a few TODOs, namely:

  • Fuzzy querying
  • Attribute-based mapping
  • Unit and integration tests

I'll get around to completing those, but I think this is a pretty functional first pass.

@Mpdreamz
Copy link
Member

Mpdreamz commented Nov 4, 2013

thanks for the update, you can leave out the attribute based mapping, it will be phased out and only used for the quick wins if you will, forcing a property name or declaring which property is the Is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants