Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machine .h files should forward declare classes when attributeValueClassName is used #11

Closed
seanm opened this issue Jan 16, 2010 · 6 comments

Comments

@seanm
Copy link
Contributor

seanm commented Jan 16, 2010

We've been using an old mogenerator and just tried 1.16. I notice that it's still not forward declaring classes that are specified for transformable-type attributes using attributeValueClassName.

In our custom templates, we added this to solve the problem:

<$foreach Attribute noninheritedAttributes do$><$if Attribute.hasTransformableAttributeType$>@Class <$Attribute.objectAttributeType$>;<$endif$>

Could it be added?

@seanm
Copy link
Contributor Author

seanm commented Jan 16, 2010

Actually, just noticed that with 1.16 using my custom template fails with this message:

Caught: NSUnknownKeyException: [<NSAttributeDescription 0x1118f0> valueForUndefinedKey:]: this class is not key value coding-compliant for the key hasTransformableAttributeType.

@rentzsch
Copy link
Owner

rentzsch commented Jul 1, 2010

Figure out any solution to this?

@seanm
Copy link
Contributor Author

seanm commented Jul 20, 2010

My colleague paugus fixed this bug in his branch. Would be great if you could review and merge.

@rentzsch
Copy link
Owner

Which commit? This one? That diff is pretty confusing.

@seanm
Copy link
Contributor Author

seanm commented Jul 21, 2010

Whoa, that one is confusing... perhaps due to our being new to git (ugh, it's UI is awful).

I've created my own branch, and manually merged his changes. This looks better:
http://github.com/seanm/mogenerator/commit/fbb156268d2a6fd5668fe43dc4c815ddeca4b1d8

@rentzsch
Copy link
Owner

Thanks! Closing.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants