Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-dp) close/unlink the dp access log unix socket #1574

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

nickolaev
Copy link
Contributor

Summary

Sanitize the Unix domain socket used by kuma-dp for providing the access-log service.

Documentation

  • Not needed

Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jakubdyszkiewicz
Copy link
Contributor

it's fix(kuma-dp)

@nickolaev nickolaev changed the title fix(*) close/unlink the dp access log unix socket fix(kuma-dp) close/unlink the dp access log unix socket Feb 18, 2021
@nickolaev nickolaev merged commit efbbd0b into master Feb 18, 2021
@nickolaev nickolaev deleted the fix/unlink_dp_unix_socket branch February 18, 2021 11:18
mergify bot pushed a commit that referenced this pull request Feb 18, 2021
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
(cherry picked from commit efbbd0b)

# Conflicts:
#	app/kuma-dp/pkg/dataplane/accesslogs/server.go
nickolaev pushed a commit that referenced this pull request Feb 18, 2021
…1578)

* fix(kuma-dp) close/unlink the dp access log unix socket (#1574)

Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
(cherry picked from commit efbbd0b)

# Conflicts:
#	app/kuma-dp/pkg/dataplane/accesslogs/server.go

* fix(*) conflict

Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>

Co-authored-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants