Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests) parametrize kuma tracing in ZipkinCollectorURL #2635

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Parametrize Kuma tracing namespace in ZipkinCollectorURL

Issues resolved

No issues.

Documentation

No docs.

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • No backporting

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner August 23, 2021 13:09
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jakubdyszkiewicz jakubdyszkiewicz merged commit 73c454e into master Aug 23, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/param-kuma-tracing branch August 23, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants