Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GitHub Stars Display Functionality in Toolpad #3371

Closed
gurjeetsinghvirdee opened this issue Apr 8, 2024 · 5 comments
Closed

Implement GitHub Stars Display Functionality in Toolpad #3371

gurjeetsinghvirdee opened this issue Apr 8, 2024 · 5 comments
Labels
out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)

Comments

@gurjeetsinghvirdee
Copy link

gurjeetsinghvirdee commented Apr 8, 2024

Summary

This feature fetches the number of stars from your GitHub repository using the GitHub API. Upon loading the webpage, JavaScript retrieves the star count and dynamically updates it beside the GitHub icon on the UI header. This ensures visitors can easily see the popularity of your repository at a glance, as the displayed count always reflects the current number of stars.

Examples

No response

Motivation

The purpose of this feature is to provide visitors with immediate visibility into the popularity of our GitHub repository. By fetching the number of stars using the GitHub API and dynamically updating it beside the GitHub icon

Search keywords: GitHub Star

@gurjeetsinghvirdee gurjeetsinghvirdee added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Apr 8, 2024
@bharatkashyap
Copy link
Member

@gurjeetsinghvirdee Is this a feature request for the Toolpad editor? I don't see how, but please elaborate on what this issue is about.

@bharatkashyap bharatkashyap added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Apr 9, 2024
@gurjeetsinghvirdee
Copy link
Author

@gurjeetsinghvirdee Is this a feature request for the Toolpad editor? I don't see how, but please elaborate on what this issue is about.

The requested feature is not specifically related to Toolpad editor functionality but rather concerns an enhancement to the web application's header UI. I aim to improve user engagement and experience by dynamically fetching and displaying the number of stars the GitHub repository has received alongside the GitHub icon in the header.

Sorry for the confusion

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Apr 9, 2024
@bharatkashyap
Copy link
Member

@gurjeetsinghvirdee We have a star count on the landing page already on https://mui.com/toolpad. Changing the GitHub icon in the header would require changes to the AppHeader which is shared across all product websites; so far we haven't considered adding a star count to header enough of a need so I would advise against creating an issue for this on the Material UI repo.

@bharatkashyap
Copy link
Member

@gurjeetsinghvirdee If your intent was to add a functionality to Toolpad where the built application can include a functionality to fetch and display GitHub stars for any repository, please let me know and I'll reopen this issue as a request to be able to modify the header UI of applications built with Toolpad

@gurjeetsinghvirdee
Copy link
Author

@bharatkashyap
I'd be happy to work on this.
Could you please assign me the task!

@gurjeetsinghvirdee gurjeetsinghvirdee changed the title Update Header UI to show GitHub stars Implement GitHub Stars Display Functionality in Toolpad Apr 10, 2024
@oliviertassinari oliviertassinari added out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)
Projects
None yet
Development

No branches or pull requests

3 participants