Added new functions, modified argument types, fixed typo #37
Conversation
…unctions Signed-off-by: aquaticus <1891400+aquaticus@users.noreply.github.com>
| SortableOIDType* oidType = buildOIDWithPrefix(oid, overwritePrefix); | ||
| if(!oidType) return nullptr; | ||
| return addHandler(new ReadOnlyStringCallback(oidType, value), false); | ||
| } | ||
|
|
||
| ValueCallback* SNMPAgent::addOpaqueHandler(char* oid, uint8_t* value, size_t data_len, bool isSettable, bool overwritePrefix){ | ||
|
|
||
| ValueCallback* SNMPAgent::addOpaqueHandler(const char *oid, uint8_t* value, size_t data_len, bool isSettable, bool overwritePrefix){ |
There was a problem hiding this comment.
I believe making the oid a const char* will remove the ability to dynamically create OID's when setting up the agent.
I have some projects where I need to dynamically create OID handlers on the fly, that are not known at compile time, so I think this will need to stay as char *.
Thoughts?
There was a problem hiding this comment.
The compiler automatically converts char* to const char*. This is absolutely safe and acceptable (you won't get compilation error). You can pass both const strings and non-const char tables to function with const char* argument.
Opposite (const char* to char*) is treated as an error by any modern compiler (unless you cast to char*).
With const char* oid type both usages are valid:
// non-const dynamic string
char tmp[32];
sprintf(tmp, "Hello");
addOpaqueHandler(tmp,...); //OK
// const string
addOpaqueHandler("Hello",...); //OKThe only scenario you would like char* oid type is when the function modifies oid. As far as I know this is not the case (correct me if I'm wrong).
There was a problem hiding this comment.
Ah of course, You've quite right. Sorry I clearly had a brain fart.
Thanks for the detailed explanation!
|
Thanks A lot for this contribution, it looks great. |
|
Need to fix the CI tests, but I ran locally and things look good. |
const char* oidinstead ofchar* oidas argumentconst string&instead ofstringaddDynamicIntegerHandler()addDynamicReadOnlyTimestampHandler()addDynamicReadOnlyStringHandler()int(not onlyint*)addGugeHandler()marked as depreciated (new functionaddGaugeHandler()).