From 29938e9182488e2cbad886c70acfb52079039be3 Mon Sep 17 00:00:00 2001
From: Jovi De Croock <decroockjovi@gmail.com>
Date: Mon, 18 Dec 2023 13:18:24 +0100
Subject: [PATCH] avoid erroring on known client side directives (#144)

---
 .changeset/khaki-clouds-marry.md              |  5 ++++
 .../example-external-generator/src/index.tsx  |  2 +-
 packages/example/src/index.ts                 |  2 +-
 packages/graphqlsp/src/diagnostics.ts         | 24 +++++++++++++++++++
 4 files changed, 31 insertions(+), 2 deletions(-)
 create mode 100644 .changeset/khaki-clouds-marry.md

diff --git a/.changeset/khaki-clouds-marry.md b/.changeset/khaki-clouds-marry.md
new file mode 100644
index 00000000..85bcfd89
--- /dev/null
+++ b/.changeset/khaki-clouds-marry.md
@@ -0,0 +1,5 @@
+---
+'@0no-co/graphqlsp': patch
+---
+
+Don't error on known client-side directives
diff --git a/packages/example-external-generator/src/index.tsx b/packages/example-external-generator/src/index.tsx
index b67df630..f6d3f674 100644
--- a/packages/example-external-generator/src/index.tsx
+++ b/packages/example-external-generator/src/index.tsx
@@ -3,7 +3,7 @@ import { graphql } from './gql';
 
 const x = graphql(`
   query Pok($limit: Int!) {
-    pokemons(limit: $limit) {
+    pokemons(limit: $limit) @populate {
       id
       name
       fleeRate
diff --git a/packages/example/src/index.ts b/packages/example/src/index.ts
index 1b70a274..07a91d81 100644
--- a/packages/example/src/index.ts
+++ b/packages/example/src/index.ts
@@ -3,7 +3,7 @@ import { Pokemon, PokemonFields, WeakFields } from './Pokemon';
 
 const x = gql`
   query Pok($limit: Int!) {
-    pokemons(limit: $limit) {
+    pokemons(limit: $limit) @populate {
       id
       name
       fleeRate
diff --git a/packages/graphqlsp/src/diagnostics.ts b/packages/graphqlsp/src/diagnostics.ts
index 9c1084c0..e06d28b9 100644
--- a/packages/graphqlsp/src/diagnostics.ts
+++ b/packages/graphqlsp/src/diagnostics.ts
@@ -21,6 +21,21 @@ import {
 import { resolveTemplate } from './ast/resolve';
 import { generateTypedDocumentNodes } from './graphql/generateTypes';
 
+const clientDirectives = new Set([
+  'populate',
+  'client',
+  '_optional',
+  '_required',
+  'arguments',
+  'argumentDefinitions',
+  'connection',
+  'refetchable',
+  'relay',
+  'required',
+  'inline',
+]);
+const directiveRegex = /Unknown directive "@([^)]+)"/g;
+
 export const SEMANTIC_DIAGNOSTIC_CODE = 52001;
 export const MISSING_OPERATION_NAME_CODE = 52002;
 export const MISSING_FRAGMENT_CODE = 52003;
@@ -181,6 +196,15 @@ const runDiagnostics = (
         undefined,
         docFragments
       )
+        .filter(diag => {
+          if (!diag.message.includes('Unknown directive')) return true;
+
+          const [message] = diag.message.split('(');
+          const matches = directiveRegex.exec(message);
+          if (!matches) return true;
+          const directiveNmae = matches[1];
+          return !clientDirectives.has(directiveNmae);
+        })
         .map(x => {
           const { start, end } = x.range;