node: fix HTTP server always force closing (ethereum#25755)

Co-authored-by: Felix Lange <fjl@twurst.com>
0x2mev · Sep 14, 2022 · 25b35c9 · 25b35c9
1 parent 9d71716
commit 25b35c9
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/node/rpcstack.go b/node/rpcstack.go
@@ -267,13 +267,15 @@ func (h *httpServer) doStop() {
 		h.wsHandler.Store((*rpcHandler)(nil))
 		wsHandler.server.Stop()
 	}
+
 	ctx, cancel := context.WithTimeout(context.Background(), shutdownTimeout)
 	defer cancel()
 	err := h.server.Shutdown(ctx)
-	if err == ctx.Err() {
+	if err != nil && err == ctx.Err() {
 		h.log.Warn("HTTP server graceful shutdown timed out")
 		h.server.Close()
 	}
+
 	h.listener.Close()
 	h.log.Info("HTTP server stopped", "endpoint", h.listener.Addr())