Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] include link to source in config options #11

Closed
gandrille opened this issue Sep 24, 2018 · 6 comments
Closed

[Enhancement] include link to source in config options #11

gandrille opened this issue Sep 24, 2018 · 6 comments

Comments

@gandrille
Copy link

Can you add a checkbox in the configuration page to decide if the link to the source web page should be included at the beginning of the copied text ?

PS: in all cases, thanks a LOT for your extension !

@0x6b
Copy link
Owner

0x6b commented Sep 25, 2018

Hi @gandrille, appreciate your feedback!

Do you mean you don't want the extension include link to the source in the beginning of copied text, just want a copied markdown text only, right? Let me confirm your use case. Thank you.

@gandrille
Copy link
Author

Hi 0x6b,
Yes, this is what I mean.

@0x6b
Copy link
Owner

0x6b commented Sep 25, 2018

@gandrille, I got your point. Give me some time to implement!

@0x6b 0x6b mentioned this issue Sep 25, 2018
@0x6b 0x6b closed this as completed in #12 Sep 25, 2018
@0x6b
Copy link
Owner

0x6b commented Sep 25, 2018

@gandrille, I have just released v0.4.0 which includes the setting. Please try this on your setup. If you find any unexpected behavior, please file an issue. Thanks!

https://addons.mozilla.org/en-US/firefox/addon/copy-selection-as-markdown/versions/0.4.0

@gandrille
Copy link
Author

Just perfect! This is the exact behavior I was expecting.
Thanks a lot!

PS: if you have a paypal account, I would be happy to offer you a beer ;-)
see for example http://zim-wiki.org/contribute.html
This is ssth you can include in the README.md of your github repository

@0x6b
Copy link
Owner

0x6b commented Sep 27, 2018

@gandrille thanks a lot for your confirmation. Setting up a PayPal for a beer will be on my todo list. Anyway thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants