Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "withNetwork" for testcontainers to e2e-implementation #1224

Closed
0xERR0R opened this issue Nov 7, 2023 · 0 comments · Fixed by #1316
Closed

add "withNetwork" for testcontainers to e2e-implementation #1224

0xERR0R opened this issue Nov 7, 2023 · 0 comments · Fixed by #1316
Labels
🧰 technical debts Technical debts, refactoring
Milestone

Comments

@0xERR0R
Copy link
Owner

0xERR0R commented Nov 7, 2023

With following PR, testcontainers introduced "withNetwork" function. We should use it instead of own function.

see testcontainers/testcontainers-go#1894

@kwitsch kwitsch added the 🧰 technical debts Technical debts, refactoring label Nov 12, 2023
@kwitsch kwitsch added this to the future milestone Dec 8, 2023
@0xERR0R 0xERR0R modified the milestones: future, v0.24 Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧰 technical debts Technical debts, refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants