Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No notification of config syntax errors #69

Closed
pksml85 opened this issue Jan 28, 2023 · 1 comment
Closed

No notification of config syntax errors #69

pksml85 opened this issue Jan 28, 2023 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@pksml85
Copy link

pksml85 commented Jan 28, 2023

First of all, thanks for writing this great software! It will help me manage my servers with ease.

I prefer to edit my site config files using the 'Manage Configs' link (because my configs get messed up by the auto-formatting when using the 'Manage Sites' --> 'Modify' method). Upon saving the file in 'Manage Configs', the changes take effect immediately, which is very nice. But if I forget a trailing semicolon or mess something else up, I am completely unaware of it. Nginx-UI just reports success on the save.

My suggestion would be: upon any config change, run 'nginx -t' to make sure the config is valid. If the config is not valid, don't save the file, but instead make a modal pop up with the error message(s) and give options like "Don't save" or "Save anyway."

Note: When clicking the 'reload nginx' graphic at the top of the UI, the same issue exists. It will report success, even if config errors are detected. Again, a modal would be wonderful indicating the error(s) and have the options "Don't reload" or "Reload anyway."

The problem with both of these features as they are is that a particular site (with syntax errors) may stop functioning and you won't be aware of it. Fixing this would make this software so much more helpful.

Thanks for your consideration!

@0xJacky
Copy link
Owner

0xJacky commented Jan 29, 2023

Thank you for your appreciation and feedback. This feature will be added in next version.

@0xJacky 0xJacky added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jan 29, 2023
0xJacky added a commit that referenced this issue Jan 31, 2023
@0xJacky 0xJacky added the bug Something isn't working label Jan 31, 2023
0xJacky added a commit that referenced this issue Jan 31, 2023
@0xJacky 0xJacky closed this as completed Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants