Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MaxTxBytesSize/MaxTxDataBytesSize default values #2086

Closed
agnusmor opened this issue May 9, 2023 · 0 comments · Fixed by #2090
Closed

Change MaxTxBytesSize/MaxTxDataBytesSize default values #2086

agnusmor opened this issue May 9, 2023 · 0 comments · Fixed by #2090
Assignees
Milestone

Comments

@agnusmor
Copy link
Contributor

agnusmor commented May 9, 2023

Rationale

The MaxTxBytesSize and MaxTxDataBytesSize config parameters limits the size of the L2 Tx. The current default values 30132 and 30000 are causing some issues in mainnet/public environments, as some dapps needs to send L2 tx greaters than these values.

Implementation

We need to increase the value of this parameters in all the toml config files and also for the default value (default.go). The maximum size set in the SC for a L1 tx is 120000, therefore we can set the default values for MaxTxBytesSize to 100132 and MaxTxDataBytesSize to 100000. This values left some margin to the max value accepted by the SC

@agnusmor agnusmor added this to the Release 0.1.0 milestone May 9, 2023
@agnusmor agnusmor self-assigned this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant