Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional metadata to decoder errors #121

Closed
BGluth opened this issue Mar 22, 2024 · 0 comments · Fixed by #148
Closed

Add additional metadata to decoder errors #121

BGluth opened this issue Mar 22, 2024 · 0 comments · Fixed by #148
Assignees
Labels
crate: trace_decoder Anything related to the trace_decoder crate.
Milestone

Comments

@BGluth
Copy link
Contributor

BGluth commented Mar 22, 2024

It would be kind of nice to adjust the error type returned by processing a trace to wrap the actual error with additional metadata along these lines:

Block num: 19240118
Txn idx: 145
Address: 0xfa7093cdd9ee6932b4eb2c9e1cde7ce00b1fa4b9
Hashed address: 0x5f3894a1bacf9d3f41232eb5c05d070fce1a22b37da1d990e09f4c3df82bc9c6
Slot: 0x00000000000000000000000000000000000000000000000000000000000000fe
Slot hashed: 0x54075df80ec1ae6ac9100e1fd0ebf3246c17f5c933137af392011f4c5f61513a
Slot value written: 0x12594b0
Txn hash: 0x6641bb9ae913e1fecddf9e6005e78b57c7877f5fd7acbf66189b2c11728a218f

I'm often needing this information while debugging, and having to not manually extract every time would be worthwhile. Impl should be easy.

Not all of these fields will be available in every single circumstance, but we could sort of dynamically build it up each time based on what is.

@BGluth BGluth added the crate: trace_decoder Anything related to the trace_decoder crate. label Mar 22, 2024
@BGluth BGluth added this to Zero EVM Mar 22, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Zero EVM Mar 22, 2024
@BGluth BGluth changed the title Add additional meta data to decoder errors Add additional metadata to decoder errors Mar 22, 2024
@vgnom vgnom added this to the Cleanups and Misc. milestone Mar 25, 2024
@vladimir-trifonov vladimir-trifonov moved this from Backlog to Ready to Review in Zero EVM Apr 8, 2024
@Nashtare Nashtare linked a pull request Apr 9, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in Zero EVM Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: trace_decoder Anything related to the trace_decoder crate.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants