Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge new_txn_trie_node_byte in TxnMeta from trace protocol #248

Closed
frisitano opened this issue May 24, 2024 · 3 comments · Fixed by #477
Closed

Purge new_txn_trie_node_byte in TxnMeta from trace protocol #248

frisitano opened this issue May 24, 2024 · 3 comments · Fixed by #477
Assignees
Labels
crate: trace_decoder Anything related to the trace_decoder crate.

Comments

@frisitano
Copy link
Contributor

From my inspection the new_txn_trie_node_byte field in TxnMeta (seen below) is unused and therefore it can be purged from the trace protocl.

/// Structure holding metadata for one transaction.
#[serde_as]
#[derive(Debug, Deserialize, Serialize)]
pub struct TxnMeta {
    /// Txn byte code.
    #[serde_as(as = "FromInto<ByteString>")]
    pub byte_code: Vec<u8>,

    /// Rlped bytes of the new txn value inserted into the txn trie by
    /// this txn. Note that the key is not included and this is only the rlped
    /// value of the node!
    #[serde_as(as = "FromInto<ByteString>")]
    pub new_txn_trie_node_byte: Vec<u8>,

    /// Rlped bytes of the new receipt value inserted into the receipt trie by
    /// this txn. Note that the key is not included and this is only the rlped
    /// value of the node!
    #[serde_as(as = "TryFromInto<ByteString>")]
    pub new_receipt_trie_node_byte: Vec<u8>,

    /// Gas used by this txn (Note: not cumulative gas used).
    pub gas_used: u64,
}
@github-project-automation github-project-automation bot moved this to Backlog in Zero EVM May 24, 2024
@frisitano frisitano changed the title Purge new_txn_trie_node_byte from TxnMeta from trace protocol Purge new_txn_trie_node_byte in TxnMeta from trace protocol May 24, 2024
@Nashtare
Copy link
Collaborator

cc @cffls

@cffls
Copy link

cffls commented May 24, 2024

Agreed, this field could be removed.

@BGluth
Copy link
Contributor

BGluth commented May 30, 2024

Yeah, I probably should have created an issue for this a while back.

@Nashtare Nashtare added this to the Cleanups and Misc. milestone Jun 8, 2024
@Nashtare Nashtare added the crate: trace_decoder Anything related to the trace_decoder crate. label Jun 14, 2024
@Nashtare Nashtare modified the milestones: Misc., Performance Tuning Jul 12, 2024
@Nashtare Nashtare self-assigned this Aug 8, 2024
@Nashtare Nashtare moved this from Backlog to In Progress in Zero EVM Aug 13, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Zero EVM Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: trace_decoder Anything related to the trace_decoder crate.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants