Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(zero-bin): verifier binary not picking up pre-processed circuits #465

Closed
Nashtare opened this issue Aug 5, 2024 · 2 comments
Closed
Assignees
Labels
bug Something isn't working crate: zero_bin Anything related to the zero-bin subcrates.

Comments

@Nashtare
Copy link
Collaborator

Nashtare commented Aug 5, 2024

I noticed in the CI logs that the jobs running the verifier binary have it re-generate all circuits.

The verifier data should exist on disk, being serialized at the same time as the prover circuits during initial preprocessing, hinting that there may be some issues on the verifier side.

@Nashtare Nashtare added bug Something isn't working crate: zero_bin Anything related to the zero-bin subcrates. labels Aug 5, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Zero EVM Aug 5, 2024
@Nashtare Nashtare added this to the Testing and Validation milestone Aug 6, 2024
@temaniarpit27 temaniarpit27 moved this from Backlog to In Progress in Zero EVM Aug 6, 2024
@temaniarpit27
Copy link
Contributor

temaniarpit27 commented Aug 7, 2024

@Nashtare

2024-08-07T06:13:39.848563Z  INFO zero_bin_common::prover_state: initializing prover state...
2024-08-07T06:13:39.848621Z  INFO zero_bin_common::prover_state: attempting to load preprocessed circuits from disk...
2024-08-07T06:13:41.055246Z  INFO zero_bin_common::prover_state: successfully loaded preprocessed circuits from disk
2024-08-07T06:13:41.055492Z  INFO leader: Proving interval 5..8

I see these logs being printed on the console while running the verifier.
Can you point me out to the logs where you see circuits being regenerated?
I have tried deleting and generating the circuits again and then running the verifier, it is using preprocessed circuits.

Maybe we are doing this step in CI
https://github.com/0xPolygonZero/zk_evm/blob/develop/.github/workflows/jerigon-native.yml#L88
That's why?

@Nashtare
Copy link
Collaborator Author

Nashtare commented Aug 7, 2024

@temaniarpit27 if you look at your logs you'll see you're not calling the verifier binary but the prover.

As for the line you shared in the CI, it's removing log files and leftover proofs, but not the circuits. I could reproduce the issue locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Status: Done
Development

No branches or pull requests

2 participants