Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't compile a regex in a loop in trie_diff #721

Closed
0xaatif opened this issue Oct 13, 2024 · 1 comment · Fixed by #758
Closed

Don't compile a regex in a loop in trie_diff #721

0xaatif opened this issue Oct 13, 2024 · 1 comment · Fixed by #758
Labels
crate: zero_bin Anything related to the zero-bin subcrates.

Comments

@0xaatif
Copy link
Contributor

0xaatif commented Oct 13, 2024

let re = Regex::new(r"block:(\d+) batch:(\d+)")?;

https://docs.rs/lazy-regex/latest/lazy_regex/macro.regex_captures.html

Let's also get rid of the indexing and use a nice library for this

@0xaatif
Copy link
Contributor Author

0xaatif commented Oct 13, 2024

cc @atanmarko

@0xaatif 0xaatif added the crate: zero_bin Anything related to the zero-bin subcrates. label Oct 13, 2024
@0xaatif 0xaatif added this to the System strengthening milestone Oct 13, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Zero EVM Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant