Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

packages/sol-compiler/src/solc/bin_paths.ts missing solc 0.5.3. Error message unhelpful #1578

Closed
BlinkyStitt opened this issue Feb 3, 2019 · 0 comments · Fixed by #1596
Closed
Assignees

Comments

@BlinkyStitt
Copy link
Contributor

I tried to run sol-compiler on my project and it didn't detect any versions.

Expected Behavior

Running sol-compiler should work when all contracts use solc 0.5.3.

Current Behavior

# sol-compiler 
Artifact for X does not exist
Artifact for Y does not exist
Artifact for Z does not exist
Compiling 3 contracts (X.sol,Y.sol,Z.sol) with Solidity vnull...
Error: null is not a known compiler version
    at Object.<anonymous> (/usr/src/app/node_modules/@0x/sol-compiler/src/utils/compiler.ts:279:15)
    at step (/usr/src/app/node_modules/@0x/sol-compiler/lib/src/utils/compiler.js:32:23)
    at Object.next (/usr/src/app/node_modules/@0x/sol-compiler/lib/src/utils/compiler.js:13:53)
    at /usr/src/app/node_modules/@0x/sol-compiler/lib/src/utils/compiler.js:7:71
    at new Promise (<anonymous>)
    at __awaiter (/usr/src/app/node_modules/@0x/sol-compiler/lib/src/utils/compiler.js:3:12)
    at Object.getSolcAsync (/usr/src/app/node_modules/@0x/sol-compiler/lib/src/utils/compiler.js:337:12)
    at Compiler.<anonymous> (/usr/src/app/node_modules/@0x/sol-compiler/src/compiler.ts:256:61)
    at step (/usr/src/app/node_modules/@0x/sol-compiler/lib/src/compiler.js:43:23)
    at Object.next (/usr/src/app/node_modules/@0x/sol-compiler/lib/src/compiler.js:24:53)

Possible Solution

  1. If an unknown version of solc is found, give an error saying so.
  2. Add solc 0.5.3 to the list. development branch is up to 0.5.2
  3. There should probably be an automated way to get new versions added to this list.

Steps to Reproduce (for bugs)

Have a project with contracts that all have pragma solc 0.5.3;.

Your Environment

sol-compiler": "2.0.2"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants