Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove breaking /bin/ path specification #91

Merged
merged 1 commit into from
Jan 24, 2024
Merged

remove breaking /bin/ path specification #91

merged 1 commit into from
Jan 24, 2024

Conversation

fsnkty
Copy link
Contributor

@fsnkty fsnkty commented Jan 24, 2024

specifying the path /bin/ here is unnecessary and breaks unconventional systems ( like nixos )
e.g.. /bin/which does not exist, but which is within my path.

if you'll merge this pr I'll be making a PR with nixpkgs for the nix package I've made for this project :)

@fsnkty
Copy link
Contributor Author

fsnkty commented Jan 24, 2024

force pushed to sign commit with ammend.

@0xk1f0
Copy link
Owner

0xk1f0 commented Jan 24, 2024

Thanks! Good to know this also works on NixOS!

@0xk1f0 0xk1f0 merged commit c35a0da into 0xk1f0:master Jan 24, 2024
1 check passed
@0xk1f0
Copy link
Owner

0xk1f0 commented Jan 24, 2024

drafted a new release for this, see v0.1.8

@fsnkty
Copy link
Contributor Author

fsnkty commented Jan 27, 2024

NixOS/nixpkgs#284144

@fsnkty
Copy link
Contributor Author

fsnkty commented Feb 13, 2024

lol this was finally merged, now i have to go about making an update PR!
should hopefully not take as long however :)

@0xk1f0
Copy link
Owner

0xk1f0 commented Feb 13, 2024

Awesome! Will update the README to reflect. Thank you for submitting, glad this utility is useful to some people :)

@fsnkty
Copy link
Contributor Author

fsnkty commented Feb 13, 2024

NixOS/nixpkgs#288444
nvm bots got to it before me, sweet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants