From 93508ea35b68cb3b07fabdecf52ff728c0981e0e Mon Sep 17 00:00:00 2001 From: Quentin JEROME Date: Tue, 22 Oct 2019 21:05:09 +0200 Subject: [PATCH] Fixed issues: #9 #10 --- collector/forwarder.go | 1 + tools/whids/hookdefs.go | 65 +++++++++++++++++++++++------------------ 2 files changed, 37 insertions(+), 29 deletions(-) diff --git a/collector/forwarder.go b/collector/forwarder.go index aa7a978..8cd0b9a 100644 --- a/collector/forwarder.go +++ b/collector/forwarder.go @@ -300,6 +300,7 @@ func (f *Forwarder) ProcessQueue() { fd.Close() case strings.HasSuffix(fp, ".log.1"), strings.HasSuffix(fp, ".log"): err = f.Client.PostLogs(fd) + fd.Close() } // We do not remove the logs if we failed to send diff --git a/tools/whids/hookdefs.go b/tools/whids/hookdefs.go index a74c1eb..4dd955c 100644 --- a/tools/whids/hookdefs.go +++ b/tools/whids/hookdefs.go @@ -42,6 +42,7 @@ type processTrack struct { PID int64 CommandLine string ParentCommandLine string + CurrentDirectory string ProcessGUID string User string ParentUser string @@ -359,36 +360,39 @@ func hookTrack(e *evtx.GoEvtxMap) { if pguid, err := e.GetString(&pathSysmonParentProcessGUID); err == nil { if user, err := e.GetString(&pathSysmonUser); err == nil { if il, err := e.GetString(&pathSysmonIntegrityLevel); err == nil { - track := &processTrack{ - Image: image, - ParentImage: pImage, - CommandLine: commandLine, - ParentCommandLine: pCommandLine, - PID: pid, - User: user, - IntegrityLevel: il, - ProcessGUID: guid, - ParentProcessGUID: pguid, - History: make([]string, 0), - Stats: stats{0, 0, 0, make(map[string]*int64)}, - } - if parent := processTracker.GetByGuid(pguid); parent != nil { - track.History = append(parent.History, parent.Image) - track.ParentUser = parent.User - track.ParentIntegrityLevel = parent.IntegrityLevel - } else { - // For processes created by System - if pimage, err := e.GetString(&pathSysmonParentImage); err == nil { - track.History = append(track.History, pimage) + if cd, err := e.GetString(&pathSysmonCurrentDirectory); err == nil { + track := &processTrack{ + Image: image, + ParentImage: pImage, + CommandLine: commandLine, + ParentCommandLine: pCommandLine, + CurrentDirectory: cd, + PID: pid, + User: user, + IntegrityLevel: il, + ProcessGUID: guid, + ParentProcessGUID: pguid, + History: make([]string, 0), + Stats: stats{0, 0, 0, make(map[string]*int64)}, + } + if parent := processTracker.GetByGuid(pguid); parent != nil { + track.History = append(parent.History, parent.Image) + track.ParentUser = parent.User + track.ParentIntegrityLevel = parent.IntegrityLevel + } else { + // For processes created by System + if pimage, err := e.GetString(&pathSysmonParentImage); err == nil { + track.History = append(track.History, pimage) + } + } + processTracker.Add(track) + e.Set(&pathAncestors, strings.Join(track.History, "|")) + if track.ParentUser != "" { + e.Set(&pathParentUser, track.ParentUser) + } + if track.ParentIntegrityLevel != "" { + e.Set(&pathParentIntegrityLevel, track.ParentIntegrityLevel) } - } - processTracker.Add(track) - e.Set(&pathAncestors, strings.Join(track.History, "|")) - if track.ParentUser != "" { - e.Set(&pathParentUser, track.ParentUser) - } - if track.ParentIntegrityLevel != "" { - e.Set(&pathParentIntegrityLevel, track.ParentIntegrityLevel) } } } @@ -766,9 +770,11 @@ func hookEnrichAnySysmon(e *evtx.GoEvtxMap) { default: hasComLine := true + // Default Values for the fields e.Set(&pathSysmonUser, "?") e.Set(&pathSysmonIntegrityLevel, "?") + e.Set(&pathSysmonCurrentDirectory, "?") if _, err := e.GetString(&pathSysmonCommandLine); err != nil { e.Set(&pathSysmonCommandLine, "?") @@ -783,6 +789,7 @@ func hookEnrichAnySysmon(e *evtx.GoEvtxMap) { } e.Set(&pathSysmonUser, track.User) e.Set(&pathSysmonIntegrityLevel, track.IntegrityLevel) + e.Set(&pathSysmonCurrentDirectory, track.CurrentDirectory) } } }