Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential issue with indexing non-published posts #21

Closed
AaronHolbrook opened this issue Jun 27, 2014 · 4 comments
Closed

Fix potential issue with indexing non-published posts #21

AaronHolbrook opened this issue Jun 27, 2014 · 4 comments
Assignees
@AaronHolbrook
Labels
confirmed bug
Milestone
Version 0.9.3

Comments

@AaronHolbrook
Copy link
Contributor

Currently the sync is set for posts that are transitioning INTO the publish status, however this doesn't address items that WERE published but are being moved to a draft or private status (or anything other than publish). These items should be removed from the index as they are no longer available for searching.
@AaronHolbrook AaronHolbrook added this to the Version 1.0 milestone Jun 27, 2014
@AaronHolbrook AaronHolbrook self-assigned this Jun 27, 2014
@tlovett1 tlovett1 reopened this Jun 27, 2014
@tlovett1 tlovett1 removed this from the Version 1.0 milestone Jul 2, 2014
@tlovett1
Copy link
Member

tlovett1 commented Jul 2, 2014

Agree this is something to think about. We need to flesh this out a lot more.

@AaronHolbrook AaronHolbrook added this to the Version 1.1 milestone Jul 29, 2014
@AaronHolbrook AaronHolbrook removed their assignment Aug 12, 2014
@AaronHolbrook
Copy link
Contributor Author

Forgot why we closed this, but this is still an issue - just verified that a published post moving into a draft state will remain in the searchable index.

@AaronHolbrook AaronHolbrook reopened this Sep 18, 2014
@AaronHolbrook AaronHolbrook self-assigned this Sep 18, 2014
@AaronHolbrook
Copy link
Contributor Author

Got a working draft, however it's breaking nearly every test - I'll be working to update the tests shortly.

@AaronHolbrook AaronHolbrook mentioned this issue Sep 19, 2014
Merged
@AaronHolbrook
Copy link
Contributor Author

This is closed by #119

@przestrzal przestrzal mentioned this issue May 30, 2022
Closed
@jahid32 jahid32 mentioned this issue Oct 3, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AaronHolbrook AaronHolbrook

Labels
confirmed bug
Projects
None yet
Milestone
Version 0.9.3
Development

No branches or pull requests
2 participants
@AaronHolbrook @tlovett1