Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In EP_Config, $global_site_config and $single_site_config property values never get set #23

Closed
AaronHolbrook opened this issue Jun 27, 2014 · 4 comments

Comments

@AaronHolbrook
Copy link
Contributor

These values never get stored and thus in the get_option function they will always return blank.

@AaronHolbrook AaronHolbrook changed the title In EP_Config, $global_site_config and $single_site_config property values never get set In EP_Config, $global_site_config and $single_site_config property values never get set Jun 27, 2014
@tlovett1 tlovett1 closed this as completed Jul 2, 2014
@AaronHolbrook
Copy link
Contributor Author

I believe @tlovett1 closed this because the values are not meant to store info, instead they set up the structure for storing - is that right @tlovett1 ?

@tlovett1
Copy link
Member

tlovett1 commented Jul 2, 2014

Correct. Thank you for clarifying. Perhaps these should be static.

@AaronHolbrook
Copy link
Contributor Author

Good idea - I'll submit a PR

@tlovett1
Copy link
Member

tlovett1 commented Jul 2, 2014

Would be helpful if you could add some documentation to that PR as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants