We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug
PHP Unit tests are failing on PHP 8. Only 5 tests have the issue.
There were 5 errors: 1) ElasticPressTest\TestSearchAlgorithm::testFilters ParseError: syntax error, unexpected token "match", expecting variable /var/www/html/wp-content/plugins/elasticpres/tests/php/TestSearchAlgorithm.php:29 2) ElasticPressTest\TestSearchAlgorithm::testLegacyFilters ParseError: syntax error, unexpected token "match", expecting variable /var/www/html/wp-content/plugins/elasticpres/tests/php/TestSearchAlgorithm.php:29 3) ElasticPressTest\TestSearchAlgorithms::testRegisterAndGetSearchAlgorithms ParseError: syntax error, unexpected token "match", expecting variable /var/www/html/wp-content/plugins/elasticpres/tests/php/TestSearchAlgorithms.php:28 4) ElasticPressTest\TestFacets::testFacetTypeRegistration ParseError: syntax error, unexpected token "match", expecting variable /var/www/html/wp-content/plugins/elasticpres/tests/php/features/TestFacet.php:24 5) ElasticPressTest\TestWeighting::testHandleSave ParseError: syntax error, unexpected token "match", expecting variable /var/www/html/wp-content/plugins/elasticpres/tests/php/features/TestWeighting.php:251
Steps to Reproduce
Expected behavior All tests should pass on PHP 8
The text was updated successfully, but these errors were encountered:
Once we have addressed this one, let's make sure we bump the PHP version used in the GitHub Action too.
Sorry, something went wrong.
@felipeelia phpunit 7.5.20 doesn't have support for PHP 8. Should I bump the version?
Yeah, that won't be simple though. There is an issue for that already: #2459
Closed by #3073
felipeelia
No branches or pull requests
Describe the bug
PHP Unit tests are failing on PHP 8. Only 5 tests have the issue.
Steps to Reproduce
Expected behavior
All tests should pass on PHP 8
The text was updated successfully, but these errors were encountered: