Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Facet options do not receive focus after selection #3201

Closed
1 task done
JakePT opened this issue Dec 13, 2022 · 1 comment · Fixed by #3209
Closed
1 task done

BUG: Facet options do not receive focus after selection #3201

JakePT opened this issue Dec 13, 2022 · 1 comment · Fixed by #3209
Assignees
@felipeelia
Labels
bug Something isn't working front end Issues mostly related to the Front End like JavaScript/React and CSS. module:instant-results Issues related to the Instant Results functionality
Milestone
4.4.1

Comments

@JakePT
Copy link
Contributor

JakePT commented Dec 13, 2022

Describe the bug

When selecting a facet option the checkbox does not receive focus after selection. This is because the checkbox is re-rendered when the new facet options are populated.

Steps to Reproduce

  1. Perform a search.
  2. Navigate to a facet checkbox with the keyboard and make a selection with Space.
  3. After the new results are loaded attempt to navigate to the next or previous facet option. This will not work as focus has returned to the beginning of the modal.

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress and ElasticPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@JakePT JakePT added bug Something isn't working front end Issues mostly related to the Front End like JavaScript/React and CSS. module:instant-results Issues related to the Instant Results functionality labels Dec 13, 2022
@JakePT JakePT self-assigned this Dec 13, 2022
@JakePT
Copy link
Contributor Author

JakePT commented Dec 13, 2022

The checkbox list component used for facets will probably need to be refactored to work around this issue.

@felipeelia felipeelia added this to the 4.4.1 milestone Dec 13, 2022
@JakePT JakePT mentioned this issue Dec 15, 2022
Merged
4 tasks
@JakePT JakePT changed the title BUG: Facet option do not receive focus after selection BUG: Facet options do not receive focus after selection Dec 15, 2022
@felipeelia felipeelia assigned felipeelia and unassigned JakePT Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipeelia felipeelia

Labels
bug Something isn't working front end Issues mostly related to the Front End like JavaScript/React and CSS. module:instant-results Issues related to the Instant Results functionality
Projects
None yet
Milestone
4.4.1
Development

Successfully merging a pull request may close this issue.

Change disabling method to avoid losing focus on facets 10up/ElasticPress
2 participants
@felipeelia @JakePT