Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Warnings due to missing defaults in CatalogCommand #33

Closed
1 task done
dsawardekar opened this issue Nov 23, 2023 · 0 comments · Fixed by #34
Closed
1 task done

PHP Warnings due to missing defaults in CatalogCommand #33

dsawardekar opened this issue Nov 23, 2023 · 0 comments · Fixed by #34
Assignees
Labels
type:bug Something isn’t working.
Milestone

Comments

@dsawardekar
Copy link
Collaborator

Describe the bug

There a few PHP Warnings in the plugin when running on PHP 8.2.

Deprecated: Optional parameter $sites declared before required parameter $opts is implicitly treated as a required parameter in /chroot/var/www/wp-content/plugins/block-catalog/includes/classes/CatalogCommand.php on line 410 

Deprecated: Optional parameter $args declared before required parameter $opts is implicitly treated as a required parameter in /chroot/var/www/wp-content/plugins/block-catalog/includes/classes/CatalogCommand.php on line 431

Steps to Reproduce

  1. With the Block Catalog Plugin active, on a PHP 8.2 environment.
  2. Run any WP CLI command like, wp --help.
  3. You will see a few PHP warnings that originate in the Block Catalog plugin.

Screenshots, screen recording, code snippet

No response

Environment information

  • PHP 8.2+

WordPress information

  • Any

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dsawardekar dsawardekar added the type:bug Something isn’t working. label Nov 23, 2023
@dsawardekar dsawardekar self-assigned this Nov 23, 2023
@ravinderk ravinderk added this to the 1.5.3 milestone Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn’t working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants