Install a different version of eslint-plugin-prettier only in our eslint Action
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… us to always do a force install. Instead install this in our eslint action
dkotter
requested review from
jeffpaul,
dsawardekar and
a team
as code owners
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In order to get
eslintto run, we had to install a newer version ofeslint-plugin-prettierin #20. The only problem here is to make this work, you have to use a force install. I don't mind doing this as part of an Action but realized anyone installing this locally would have to do the same.This PR fixes this by only installing that dependency in our
eslintAction.How to test the Change
Can see a commit with no JS changes that passed here: https://github.com/10up/block-catalog/pull/25/checks?sha=948cd4fef8f25012bd5f7825434f13d62fc8691b
Can see a commit with an error in a JS file that triggered the check here: https://github.com/10up/block-catalog/pull/25/checks?sha=a5e73388a5330f63032eaf3b62ff245c253dfc7c
Changelog Entry
None needed
Credits
Props @dkotter
Checklist: