Feature/upgrade php and phpunit #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump WordPress "tested up to" version 6.4
dsawardekar
requested review from
peterwilsoncc
and removed request for
a team
ravinderk
suggested changes
Nov 23, 2023
There was a problem hiding this comment.
@dsawardekar, I left a few comments. Let me know if you have any questions.
|
@ravinderk There were a few linter warnings. I've added those opts back with phpcs to ignore the warnings. |
ravinderk
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #33
How to test the Change
wp block-catalog indexChangelog Entry
Fixed - PHP 8.2 deprecation warnings
Added - PHPUnit 9.x support
Credits
Props @dsawardekar
Checklist: