Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated linting for PHP and JS (CI) #225

Closed
helen opened this issue Sep 29, 2020 · 1 comment
Closed

Add automated linting for PHP and JS (CI) #225

helen opened this issue Sep 29, 2020 · 1 comment
Labels
type:enhancement New feature or request.
Milestone

Comments

@helen
Copy link
Contributor

helen commented Sep 29, 2020

Is your enhancement related to a problem? Please describe.
While there is a precommit hook, it currently only runs phpcs (possibly needs to be updated) and it's still possible for somebody to ignore that and push to a branch and open a PR with those errors.

Describe the solution you'd like
I would like to see PHPCS and ESLint running in GitHub Actions with annotations, see https://github.com/helen/wordpress-develop/pull/1/files for an example.

Designs
n/a

Describe alternatives you've considered
n/a

Additional context
See #209

@helen helen added the type:enhancement New feature or request. label Sep 29, 2020
@helen helen added this to the 1.6.0 milestone Sep 29, 2020
@dinhtungdu
Copy link
Contributor

Closed by #226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants