Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOCKER] Generate/regenerate/rescan buttons do not work in media modal when editing a post #292

Closed
helen opened this issue Jul 13, 2021 · 0 comments · Fixed by #295
Closed
Assignees
Labels
type:bug Something isn't working.
Milestone

Comments

@helen
Copy link
Contributor

helen commented Jul 13, 2021

Describe the bug
Screen Shot 2021-07-13 at 9 02 16 AM

These buttons do not do anything when clicked while editing a post, as in they do not fire off a network request or show a spinner or anything like that, you can click/activate them but it just no-ops. They do work fine in the modal when on the media library screen. I think I have noticed this before intermittently and chalked it up to caching or build oddities but it seems very consistent now.

Steps to Reproduce

  1. Edit a post
  2. Bring up the media modal by inserting an image block and selecting media library
  3. Choose an image
  4. Try clicking the buttons in the side panel, observing network requests in the inspector

Expected behavior
I would expect the buttons to work the same way they do when on the media library screen.

Additional context
Side note: why do we have inconsistent labels?
Screen Shot 2021-07-13 at 9 09 04 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
2 participants