Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering of the "Re-Transcribe" button should independent of the "Generate transcripts from audio files" setting #534

Open
1 task done
Sidsector9 opened this issue Jul 13, 2023 · 2 comments
Labels
type:enhancement New feature or request. type:good-first-issue Good for newcomers.
Milestone

Comments

@Sidsector9
Copy link
Member

Sidsector9 commented Jul 13, 2023

Is your enhancement related to a problem? Please describe.

When Generate transcripts from audio files is disabled, the "Re-Transcribe" button in the Media library page is not rendered, however, we can still use CLI to Re-Transcribe. The setting description says
"Automatically generate transcripts for supported audio files", but Re-Transcribing is a manual process. So IMO we should render that button at all times, whether this setting is enabled or disabled.

Describe alternatives you've considered

We should add a separate setting to enable/disable the feature, and use this setting value as a conditional to decide whether to render the button in the GUI.

Related: PR #451, PR #514

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Sidsector9 Sidsector9 added type:enhancement New feature or request. type:good-first-issue Good for newcomers. labels Jul 13, 2023
@dkotter dkotter added this to the 2.3.0 milestone Jul 17, 2023
@jeffpaul
Copy link
Member

@Sidsector9 I think the current handling seems correct in the admin, though some might also say that the CLI should also be disabled if the main setting is disabled but I'm less worried about that than in-admin handling.

@dkotter dkotter modified the milestones: 2.3.0, 2.4.0 Aug 17, 2023
@jeffpaul
Copy link
Member

jeffpaul commented Oct 5, 2023

Perhaps alternatively where we have the ability to handle Bulk updating with the Bulk Edit and where we have the ability to use this feature via WP-CLI maybe each should be a setting to configure (with the default being enabled if the feature is enabled during initial setup)? If so, then we'd likely want to replicate that across features/service providers.

@dkotter dkotter modified the milestones: 2.4.0, 2.5.0 Nov 7, 2023
@dkotter dkotter modified the milestones: 2.5.0, 2.6.0 Dec 12, 2023
@dkotter dkotter modified the milestones: 3.1.0, 3.2.0 Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request. type:good-first-issue Good for newcomers.
Projects
None yet
Development

No branches or pull requests

3 participants