Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Admin access to the plugin's features #658

Closed
1 task done
gsarig opened this issue Jan 12, 2024 · 2 comments · Fixed by #689
Closed
1 task done

Super Admin access to the plugin's features #658

gsarig opened this issue Jan 12, 2024 · 2 comments · Fixed by #689
Assignees
Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Milestone

Comments

@gsarig
Copy link

gsarig commented Jan 12, 2024

Is your enhancement related to a problem? Please describe.

When on a multisite setup, the Super Admin role isn't listed among the Allowed Roles. Therefore, Super Admins cannot access the plugin's features unless they make themselves Administrators to the specific site. I would expect that a Super Admin would have access to any feature that a site Administrator has, even if they are not explicitly set as users on a specific site.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@gsarig gsarig added the type:enhancement New feature or request. label Jan 12, 2024
@jeffpaul
Copy link
Member

@dkotter my initial reaction here is super admins should be able to access the settings page for any site on the network and where admins are granted access to enabled features then also having access there on specific sites. Thoughts?

@jeffpaul jeffpaul added this to the 3.0.0 milestone Jan 12, 2024
@dkotter
Copy link
Collaborator

dkotter commented Jan 17, 2024

@dkotter my initial reaction here is super admins should be able to access the settings page for any site on the network and where admins are granted access to enabled features then also having access there on specific sites. Thoughts?

Yeah, I think that's a good middle ground. I know often the approach is to just give super admins access to everything (so in this case, they'd have access to all features without having to select a role) but I think equating admins and super admins in this case makes sense.

@jeffpaul jeffpaul added the help wanted Extra attention is needed label Jan 17, 2024
@dkotter dkotter self-assigned this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants