Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use better icons and show editor name #12

Merged
merged 1 commit into from
Oct 12, 2020
Merged

feat: use better icons and show editor name #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions includes/ConvertToBlocks/PostTypeColumnSupport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@ public function can_register() {
*/
public function update_post_columns( $columns ) {
$column_label = $this->get_editor_column_label();
$title_index = array_search( $title, $columns, true );

$editor_column = [
'editor' => $column_label,
];

$columns['editor'] = $column_label;

Expand Down Expand Up @@ -113,6 +108,11 @@ class="dashicons <?php echo esc_attr( $icon ); ?>"
title="<?php echo esc_attr( $title ); ?>"
>
</span>
<?php
if ( apply_filters( 'convert_to_blocks_show_admin_column_title', true ) ) {
printf( '<span class="txt">%s</span>', esc_attr( $title ) );
}
?>
<?php
}

Expand All @@ -132,7 +132,7 @@ public function get_editor_column_label() {
* @return string
*/
public function get_block_editor_column_icon() {
return apply_filters( 'convert_to_blocks_block_editor_column_icon', 'dashicons-wordpress' );
return apply_filters( 'convert_to_blocks_block_editor_column_icon', 'dashicons-columns' );
}

/**
Expand All @@ -142,7 +142,7 @@ public function get_block_editor_column_icon() {
* @return string
*/
public function get_classic_editor_column_icon() {
return apply_filters( 'convert_to_blocks_classic_editor_column_icon', 'dashicons-backup' );
return apply_filters( 'convert_to_blocks_classic_editor_column_icon', 'dashicons-media-document' );
}

/**
Expand Down