Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.json to new minimum PHP version #122

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

c0ntax
Copy link
Contributor

@c0ntax c0ntax commented Jun 28, 2023

Description of the Change

Minimum PHP support for this library is now PHP 8.0, but the composer.json file did not reflect this. Updating this will ensure that people that are using composer and wpackagist to install/maintain PHP don't take in an incompatible library

Closes #121

How to test the Change

Steps to reproduce (and therefore how to test the change) are in #121

Changelog Entry

Changed - Bump min required PHP version from 7.4 to 8.0

Credits

Checklist:

  • I agree to follow this project's Code of Conduct.
  • [n/a] I have updated the documentation accordingly.
  • [n/a] I have added tests to cover my change.
  • [n/a] All new and existing tests pass.

@c0ntax c0ntax requested review from a team and dsawardekar as code owners June 28, 2023 08:34
@c0ntax c0ntax requested review from Sidsector9 and removed request for a team June 28, 2023 08:34
@jeffpaul jeffpaul added this to the 1.2.1 milestone Jun 28, 2023
@jeffpaul jeffpaul mentioned this pull request Jun 28, 2023
4 tasks
@c0ntax c0ntax requested a review from jeffpaul as a code owner June 28, 2023 15:45
@jeffpaul jeffpaul removed their request for review June 28, 2023 15:48
Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! The changes look good to me 👍

Note: The E2E tests failing are unrelated.

@Sidsector9 Sidsector9 merged commit 409343a into 10up:develop Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimum PHP version in 1.2.0 is incorrect in composer.json
3 participants