Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't modify edit links if previous request had the classic editor query param #17

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Nov 13, 2020

Description of the Change

Currently, if you click to edit a post in the classic editor and then go back to the edit post list, the next post you click on will automatically open in the classic editor, no matter what edit option you choose.

This PR removes the code that is responsible for this, as it's not ideal to force the classic editor when a user hasn't actually selected that option.

Alternate Designs

None

Benefits

Each post you edit will open the right editing experience, irregardless of any previously selected choice

Possible Drawbacks

None

Verification Process

  1. Click to edit a post in the classic editor
  2. Go back to the post list view
  3. Click the regular edit button on a different post
  4. Note that it should open in the block editor

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes #9

…am if the previous page had the same param.
@dkotter dkotter self-assigned this Nov 13, 2020
@jeffpaul jeffpaul added this to the 1.0.1 milestone Nov 13, 2020
@jeffpaul jeffpaul requested a review from dinhtungdu November 13, 2020 14:57
@jeffpaul jeffpaul added the type:bug Something isn't working. label Nov 13, 2020
@jeffpaul jeffpaul merged commit 2427c3d into develop Nov 17, 2020
@jeffpaul jeffpaul modified the milestones: 1.0.1, 1.0.0 Jan 14, 2021
@jeffpaul jeffpaul deleted the fix/remove-classic-mode-remember branch February 8, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor selection unexpectedly defaults to previous choice
2 participants