Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createTerm tests are failing in WP minimum env. #35

Closed
1 task done
iamdharmesh opened this issue Mar 30, 2022 · 0 comments · Fixed by #37
Closed
1 task done

createTerm tests are failing in WP minimum env. #35

iamdharmesh opened this issue Mar 30, 2022 · 0 comments · Fixed by #37
Assignees
@faisal-alvi
Labels
type:bug Something isn't working. type:good-first-issue Good for newcomers.
Milestone
0.1.0

Comments

@iamdharmesh
Copy link
Member

Describe the bug

We have added WP minimum env(5.2) in GH action to test commands with 5.2 and createTerm tests are failing on it.

 1) Command: createTerm
       Should be able to Create a category:
     AssertionError: Timed out retrying after 4000ms: expected '<div.notice.notice-error.notice-alt.inline.hidden>' to contain 'Category added'

It looks like we just have to update class for notice we are checking.

Steps to Reproduce

Test createTerm against WordPress core 5.2

Screenshots, screen recording, code snippet

image

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@iamdharmesh iamdharmesh added the type:bug Something isn't working. label Mar 30, 2022
@iamdharmesh iamdharmesh mentioned this issue Mar 30, 2022
Merged
6 tasks
@iamdharmesh iamdharmesh added the type:good-first-issue Good for newcomers. label Mar 30, 2022
@faisal-alvi faisal-alvi self-assigned this Mar 30, 2022
@faisal-alvi faisal-alvi moved this to Incoming in Open Source Practice Mar 30, 2022
@faisal-alvi faisal-alvi moved this from Incoming to In Progress in Open Source Practice Mar 30, 2022
@faisal-alvi faisal-alvi mentioned this issue Mar 30, 2022
Merged
6 tasks
@faisal-alvi faisal-alvi added this to the Future Release milestone Mar 30, 2022
@faisal-alvi faisal-alvi moved this from In Progress to In Review in Open Source Practice Mar 30, 2022
Repository owner moved this from In Review to Merged in Open Source Practice Mar 31, 2022
@jeffpaul jeffpaul modified the milestones: Future Release, 0.1.0 Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@faisal-alvi faisal-alvi

Labels
type:bug Something isn't working. type:good-first-issue Good for newcomers.
Projects
Open Source Practice
Archived in project
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Fix/35 createTerm tests made compatible with WP minimum env (5.2). 10up/cypress-wp-utils
3 participants
@jeffpaul @iamdharmesh @faisal-alvi