Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logout command #2

Merged
merged 3 commits into from
Mar 7, 2022
Merged

Logout command #2

merged 3 commits into from
Mar 7, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented Mar 5, 2022 •
edited
Loading

Description of the Change

Adds logout command

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Added - logout command

Credits

Props @cadic

@cadic cadic requested a review from dinhtungdu March 5, 2022 06:30
@cadic cadic self-assigned this Mar 5, 2022
dinhtungdu
dinhtungdu approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you please fix the small typo then merge this one? 🎉

tests/cypress/integration/logout.test.js Outdated
cy.get('#login .message').should('contain', 'You are now logged out.');
});

it('Logout should not fail if not logged int', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo here

@cadic cadic merged commit 96e92f8 into trunk Mar 7, 2022
@cadic cadic deleted the add/logout branch March 7, 2022 13:20
github-actions bot pushed a commit that referenced this pull request Mar 7, 2022
@cadic
Build: (96e92f8) Merge pull request #2 from 10up/add/logout
ef8f79b 
Logout command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhtungdu dinhtungdu dinhtungdu approved these changes

Assignees

@cadic cadic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cadic @dinhtungdu