Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #49

Merged
merged 4 commits into from
Apr 14, 2022
Merged

Update readme #49

merged 4 commits into from
Apr 14, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented Apr 1, 2022

Description of the Change

Updated the readme:

  • Shields
  • Anchor text for the setup link
  • Docs for run-all-cores.sh
  • Work with us banner

Closes #47

@cadic cadic requested a review from dinhtungdu April 1, 2022 14:43
@cadic cadic self-assigned this Apr 1, 2022
@cadic cadic requested a review from iamdharmesh April 1, 2022 15:00
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cadic Thanks for adding this. LGTM!!

README.md Outdated
> Utilities library for WordPress E2E testing in the Cypress environment.

## Prerequisites

This library requires Cypress. Use https://github.com/10up/cypress-wp-setup to set up Cypress automatically.
This library requires Cypress. Use [@10up/cypress-wp-setup](https://github.com/10up/cypress-wp-setup) to set up Cypress automatically.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cadic because @10up/cypress-wp-setup now includes this library, do you think we should note that behavior here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cadic bumping this question for you^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dinhtungdu @jeffpaul added the comment about the current library included into the setup.

@cadic cadic requested a review from dinhtungdu April 14, 2022 14:05
@jeffpaul jeffpaul merged commit 47624ca into trunk Apr 14, 2022
@jeffpaul jeffpaul deleted the update/readme branch April 14, 2022 18:07
github-actions bot pushed a commit that referenced this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the readme
4 participants