Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Support WP VIP Code Standards #799

Closed
jamesmorrison opened this issue Sep 22, 2021 · 1 comment · Fixed by #901
Closed

Enhancement: Support WP VIP Code Standards #799

jamesmorrison opened this issue Sep 22, 2021 · 1 comment · Fixed by #901
Assignees
Labels
type:enhancement New feature or request.
Milestone

Comments

@jamesmorrison
Copy link
Member

Is your enhancement related to a problem? Please describe.
During a commit of Distributor to a WP VIP Go repository, the VIP Bot flagged a number of issues with the plugin codebase. [For privacy reasons, the site in question is not being identified here - contact me directly for further details.]

Describe the solution you'd like
Include the VIP code standards in tests, ensure that where practical code is updated for compatibility; where impractical PHPCS ignore rules are added.

Designs
N/A

Describe alternatives you've considered
N/A (The only alternative is not to use VIP Go)

Additional context
N/A

@jamesmorrison jamesmorrison added the type:enhancement New feature or request. label Sep 22, 2021
@jeffpaul jeffpaul added this to the Future Release milestone Sep 22, 2021
@jeffpaul
Copy link
Member

jeffpaul commented Oct 5, 2021

Here’s the ClassifAI PR that added VIPCS and fixed/ignored VIPCS issues: 10up/classifai#287. We would theoretically take a similar approach here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
Archived in project
4 participants