Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/111 Update README.md by build commands addition #112

Merged
merged 3 commits into from
Jan 26, 2022
Merged

Fix/111 Update README.md by build commands addition #112

merged 3 commits into from
Jan 26, 2022

Conversation

faisal-alvi
Copy link
Member

Description of the Change

Closes #111.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Changed - Updated README.md to include build commands.

@faisal-alvi faisal-alvi added this to the 1.0.4 milestone Jan 22, 2022
@faisal-alvi faisal-alvi requested a review from a team January 22, 2022 10:05
@faisal-alvi faisal-alvi self-assigned this Jan 22, 2022
@faisal-alvi faisal-alvi requested review from Sidsector9 and removed request for a team January 22, 2022 10:05
@jeffpaul
Copy link
Member

Looks good to me, thanks!

@jeffpaul jeffpaul merged commit 93c902e into develop Jan 26, 2022
@jeffpaul jeffpaul deleted the fix/111 branch January 26, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sidsector9 Sidsector9 Awaiting requested review from Sidsector9 Sidsector9 was automatically assigned from 10up/open-source-practice

Assignees

@faisal-alvi faisal-alvi

Labels
None yet
Projects
None yet
Milestone
1.0.4
Development

Successfully merging this pull request may close these issues.

Update read me file
2 participants
@faisal-alvi @jeffpaul