fix: copy the current formats when insertings a character #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would just insert the character at the point, however, when a character was inserted within a text format they would split the format and insert the character with no formats. With this commit we copy the current `value` and insert out character here which preserves the surrounding formatting
Sidsector9
requested changes
Feb 28, 2023
There was a problem hiding this comment.
Thank you very much for the PR!
I tested the changes and it has worked partially for me.
The formatting doesn't seem to work when the string is partially formatted.
Please watch the 2 videos below:
Working
ISC-W.mp4
Not working
ISC-NW.mp4
Let us know if you need any assistance with this PR.
Updates newValue.formats to be the length of the new text string by duplicating the formats at value.start; this fixes an issue where it breaks the remaining format if it is added within the middle
|
hey @Sidsector9 thanks for testing! I believe i have fixed this by copying the current positions formats :) Screen.Recording.2023-02-28.at.11.29.29.mov |
|
@jrmd welcome to Insert Special Characters and thanks for the PR, this is definitely a nice improvement in maintaining formatting... many thanks for the contribution! |
Sidsector9
requested changes
Mar 1, 2023
Sidsector9
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Previously we would just insert the character at the point, however, when a character was inserted within a text format they would split the format and insert the character with no formats.
With this commit we copy the current
valueand insert out character here which preserves the surrounding formattingOld Behaviour
Old.Insert.Behaviour.mov
New Behaviour
New.Behaviour.mov
How to test the Change
Create some text with a text format (bold/italic) put cursor in the middle add a special character ensure that the format isnt split by the special character
Changelog Entry
Credits
@jrmd
Checklist: