Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E run on build zip #190

Merged
merged 8 commits into from
Apr 11, 2023
Merged

E2E run on build zip #190

merged 8 commits into from
Apr 11, 2023

Conversation

jayedul
Copy link
Contributor

@jayedul jayedul commented Mar 28, 2023

Description of the Change

PR contains changes to Run E2E tests on the zip generated by "Build release zip" action to catch release zip bugs early and at the PR level instead of manual testing before release.

Closes #176

Changelog Entry

Changed - Run E2E tests on the zip generated by "Build release zip" action.

Credits

Props @jayedul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jayedul jayedul self-assigned this Mar 28, 2023
@jayedul jayedul marked this pull request as ready for review April 6, 2023 06:39
@jayedul jayedul requested review from jeffpaul and a team as code owners April 6, 2023 06:39
@jayedul jayedul mentioned this pull request Apr 6, 2023
4 tasks
@jeffpaul jeffpaul added this to the 1.0.7 milestone Apr 6, 2023
@jeffpaul jeffpaul requested review from a team and peterwilsoncc and removed request for a team and jeffpaul April 6, 2023 13:26
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor suggestion to use the file from teh same branch. I'll merge that in and make sure the tests continue to pass.

.github/workflows/cypress.yml Outdated Show resolved Hide resolved
@peterwilsoncc peterwilsoncc merged commit b2e3dd7 into develop Apr 11, 2023
@peterwilsoncc peterwilsoncc deleted the update/176 branch April 11, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run E2E tests on the zip generated by "Build release zip" action.
3 participants